Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of suggestions #91

Open
Obstbeeren opened this issue Sep 12, 2024 · 5 comments
Open

Change order of suggestions #91

Obstbeeren opened this issue Sep 12, 2024 · 5 comments

Comments

@Obstbeeren
Copy link

Is it possible to change the order of the suggestions shown? It would be great if the first suggestion was the fix and not the option to disable the lint.

image

@ematipico
Copy link
Member

Do you see the same thing on VSCode too?

@Obstbeeren
Copy link
Author

Sorry for the late answer

Yes, VSCode has the correct order (on 1.9.3). I cannot test 1.9.3 on IntelliJ because it is broken.
image

@denbezrukov
Copy link
Contributor

Hi,
I've tested on VSCode 1.9.3 and on WebStorm

Screenshot 2024-11-10 at 10 39 48 PM Screenshot 2024-11-10 at 10 40 43 PM Screenshot 2024-11-10 at 10 41 15 PM

@denbezrukov
Copy link
Contributor

@ematipico
Copy link
Member

Hm,
I get correct order if I comment this line: https://github.com/biomejs/biome/blob/95faf70dbccfe005ea031be41de2f38930badf66/crates/biome_lsp/src/handlers/analysis.rs#L205

@ematipico What do you think?

I don't know why the rev() is there. If removing it fixes the issue, let's remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants