From 893107937f177ea2d886bdb01dc12ef16b7b9a7b Mon Sep 17 00:00:00 2001 From: Victorien Elvinger Date: Mon, 9 Sep 2024 22:01:10 +0200 Subject: [PATCH] ci: fix format and lint errors --- benchmark/bench.js | 5 ++--- benchmark/eslint.config.js | 1 - benchmark/package.json | 2 +- benchmark/ts-eslint.config.js | 1 - .../biome_configuration/src/analyzer/linter/rules.rs | 2 +- .../src/lint/suspicious/no_double_equals.rs | 2 +- packages/@biomejs/backend-jsonrpc/src/workspace.ts | 2 +- packages/@biomejs/biome/configuration_schema.json | 2 +- packages/@biomejs/biome/scripts/generate-packages.mjs | 4 +++- packages/@biomejs/js-api/src/index.ts | 10 +++++----- packages/@biomejs/js-api/src/wasm.ts | 2 +- 11 files changed, 16 insertions(+), 17 deletions(-) diff --git a/benchmark/bench.js b/benchmark/bench.js index 0ba3b7f74476..b6c2c4c5f6bd 100644 --- a/benchmark/bench.js +++ b/benchmark/bench.js @@ -133,12 +133,11 @@ function benchmarkLinter(biomeBin, options) { } function shellOption() { - if (process.platform == "win32") { + if (process.platform === "win32") { // Use Powershell so that it is possible to set an environment variable for a single command (ugh!) return "powershell"; - } else { - return "default"; } + return "default"; } function withEnvVariable(name, value, command) { diff --git a/benchmark/eslint.config.js b/benchmark/eslint.config.js index 57c86fb64bae..383fb7b5418e 100644 --- a/benchmark/eslint.config.js +++ b/benchmark/eslint.config.js @@ -82,7 +82,6 @@ export default [ "no-dupe-args": "error", "no-empty": "error", "no-empty-static-block": "error", - "no-empty-static-block": "error", "no-empty-function": "error", "no-fallthrough": "error", "no-func-assign": "error", diff --git a/benchmark/package.json b/benchmark/package.json index f51fe2f43833..e64bf54c9cfb 100644 --- a/benchmark/package.json +++ b/benchmark/package.json @@ -8,7 +8,7 @@ "license": "MIT OR Apache-2.0", "type": "module", "engines": { - "node": ">20.0.0" + "node": ">20.0.0" }, "devDependencies": { "@typescript-eslint/eslint-plugin": "8.3.0", diff --git a/benchmark/ts-eslint.config.js b/benchmark/ts-eslint.config.js index a4077a09b1da..8dd6346ce7d0 100644 --- a/benchmark/ts-eslint.config.js +++ b/benchmark/ts-eslint.config.js @@ -116,7 +116,6 @@ export default [ "no-dupe-args": "error", "no-empty": "error", "no-empty-static-block": "error", - "no-empty-static-block": "error", "@typescript-eslint/no-empty-function": "error", "@typescript-eslint/no-empty-interface": "error", "@typescript-eslint/no-explicit-any": "error", diff --git a/crates/biome_configuration/src/analyzer/linter/rules.rs b/crates/biome_configuration/src/analyzer/linter/rules.rs index a71de7ec4a0a..8441e58a4892 100644 --- a/crates/biome_configuration/src/analyzer/linter/rules.rs +++ b/crates/biome_configuration/src/analyzer/linter/rules.rs @@ -5642,7 +5642,7 @@ pub struct Suspicious { #[doc = "Disallow the use of debugger"] #[serde(skip_serializing_if = "Option::is_none")] pub no_debugger: Option>, - #[doc = "Require the use of === and !=="] + #[doc = "Require the use of === and !==."] #[serde(skip_serializing_if = "Option::is_none")] pub no_double_equals: Option>, #[doc = "Disallow duplicate case labels."] diff --git a/crates/biome_js_analyze/src/lint/suspicious/no_double_equals.rs b/crates/biome_js_analyze/src/lint/suspicious/no_double_equals.rs index 19b1f0711d56..15e8f3a07dfd 100644 --- a/crates/biome_js_analyze/src/lint/suspicious/no_double_equals.rs +++ b/crates/biome_js_analyze/src/lint/suspicious/no_double_equals.rs @@ -14,7 +14,7 @@ use schemars::JsonSchema; use crate::JsRuleAction; declare_lint_rule! { - /// Require the use of `===` and `!==` + /// Require the use of `===` and `!==`. /// /// It is generally bad practice to use `==` for comparison instead of /// `===`. Double operators will trigger implicit [type coercion](https://developer.mozilla.org/en-US/docs/Glossary/Type_coercion) diff --git a/packages/@biomejs/backend-jsonrpc/src/workspace.ts b/packages/@biomejs/backend-jsonrpc/src/workspace.ts index f9da1b7e5a7f..f77dd4e4e299 100644 --- a/packages/@biomejs/backend-jsonrpc/src/workspace.ts +++ b/packages/@biomejs/backend-jsonrpc/src/workspace.ts @@ -1708,7 +1708,7 @@ export interface Suspicious { */ noDebugger?: RuleFixConfiguration_for_Null; /** - * Require the use of === and !== + * Require the use of === and !==. */ noDoubleEquals?: RuleFixConfiguration_for_NoDoubleEqualsOptions; /** diff --git a/packages/@biomejs/biome/configuration_schema.json b/packages/@biomejs/biome/configuration_schema.json index 0dcafb378411..7a137f898f7d 100644 --- a/packages/@biomejs/biome/configuration_schema.json +++ b/packages/@biomejs/biome/configuration_schema.json @@ -3557,7 +3557,7 @@ ] }, "noDoubleEquals": { - "description": "Require the use of === and !==", + "description": "Require the use of === and !==.", "anyOf": [ { "$ref": "#/definitions/NoDoubleEqualsConfiguration" }, { "type": "null" } diff --git a/packages/@biomejs/biome/scripts/generate-packages.mjs b/packages/@biomejs/biome/scripts/generate-packages.mjs index 265952cc0b90..93a8f5627b47 100644 --- a/packages/@biomejs/biome/scripts/generate-packages.mjs +++ b/packages/@biomejs/biome/scripts/generate-packages.mjs @@ -59,7 +59,9 @@ function copyBinaryToNativePackage(platform, arch) { const binaryTarget = resolve(packageRoot, `biome${ext}`); if (!fs.existsSync(binarySource)) { - console.error(`Source for binary for ${buildName} not found at: ${binarySource}`); + console.error( + `Source for binary for ${buildName} not found at: ${binarySource}`, + ); process.exit(1); } diff --git a/packages/@biomejs/js-api/src/index.ts b/packages/@biomejs/js-api/src/index.ts index a215a0454e78..3cf806474c4c 100644 --- a/packages/@biomejs/js-api/src/index.ts +++ b/packages/@biomejs/js-api/src/index.ts @@ -97,7 +97,7 @@ export class Biome { /** * It creates a new instance of the class {Biome}. */ - public static async create(options: BiomeCreate): Promise { + static async create(options: BiomeCreate): Promise { const module = await loadModule(options.distribution); const workspace = new module.Workspace(); const biome = new Biome(module, workspace); @@ -111,7 +111,7 @@ export class Biome { * After calling `shutdown()` on this object, it should be considered * unusable as calling any method on it will fail */ - public shutdown() { + shutdown() { this.workspace.free(); } @@ -122,7 +122,7 @@ export class Biome { * * @param configuration */ - public applyConfiguration(configuration: Configuration): void { + applyConfiguration(configuration: Configuration): void { try { this.workspace.updateSettings({ configuration, @@ -134,8 +134,8 @@ export class Biome { } } - public registerProjectFolder(): void; - public registerProjectFolder(path?: string): void { + registerProjectFolder(): void; + registerProjectFolder(path?: string): void { this.workspace.registerProjectFolder({ path, setAsCurrentWorkspace: true, diff --git a/packages/@biomejs/js-api/src/wasm.ts b/packages/@biomejs/js-api/src/wasm.ts index 2f751bf9b980..119a7a29532b 100644 --- a/packages/@biomejs/js-api/src/wasm.ts +++ b/packages/@biomejs/js-api/src/wasm.ts @@ -65,7 +65,7 @@ class WasmError extends Error { * * It might be useful, but the first like of the stack trace contains the error */ - public stackTrace: string; + stackTrace: string; private constructor(stackTrace: string) { super(); this.stackTrace = stackTrace;