Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Implement selector-type-no-unknown #2543

Closed
Tracked by #2511
vasucp1207 opened this issue Apr 21, 2024 · 6 comments · Fixed by #2871
Closed
Tracked by #2511

📎 Implement selector-type-no-unknown #2543

vasucp1207 opened this issue Apr 21, 2024 · 6 comments · Fixed by #2871
Assignees
Labels
A-Linter Area: linter L-CSS Language: CSS

Comments

@vasucp1207
Copy link
Member

No description provided.

@vasucp1207 vasucp1207 self-assigned this Apr 21, 2024
@vasucp1207 vasucp1207 added A-Linter Area: linter L-CSS Language: CSS labels Apr 21, 2024
@Kazuhiro-Mimaki
Copy link
Contributor

I'm interested in tackling this issue 🦀

@vasucp1207
Copy link
Member Author

Currently, I have a busy schedule, so go for it 👍

I'm interested in tackling this issue 🦀

@togami2864
Copy link
Contributor

@Kazuhiro-Mimaki Regarding this rule, it would be better to implement the behavior like when stylelint's ignore: ['custom-elements'] is enabled, as it allows users to adopt the recommended configuration without any additional adjustments.

@Kazuhiro-Mimaki
Copy link
Contributor

@togami2864
Do you mean it would be better to implement the options?

@togami2864
Copy link
Contributor

@Kazuhiro-Mimaki
I meant that it would be better for the default behavior of Biome to mimic that of 'stylelint' when used the following options

module.exports = {
	rules: {
		'selector-type-no-unknown': [
			true,
			{
				ignore: ['custom-elements'],
			},
		],
	},
};

rather than the default behavior of 'stylelint' with no options.
I think it's beneficial to be able to use these by simply running 'biome init', without the need to add any configuration.

@Kazuhiro-Mimaki
Copy link
Contributor

I understood, thank you for your detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-CSS Language: CSS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants