🐛 Plugin ignores overrides in config

[ska-kialo]

VS Code version

1.88.1

Extension version

2.2.2

Biome version

1.7.0

Operating system

• Windows
• macOS
• Linux

Description

If a lint rule is enabled in the main "linter" property in biome.json and then overridden for some files in the overrides list, this override is ignored by the plugin.

Steps to reproduce

1. Create a biome.json and enable an auto-fixable lint rule (e.g. style/useEnumInitializers).
2. Create an overrides section and disable that same rule in there for some (or all) TypeScript files.
3. Enable auto-fixing files with biome on explicit save in VSCode.
4. Save a file with some code that violates the rule.
5. Explicitly save the file.
6. The file contents are modified with an auto-fix for the lint rule.

biome.json:

{
    "$schema": "https://biomejs.dev/schemas/1.7.0/schema.json",
    "organizeImports": { "enabled": false },
    "linter": {
        "enabled": true,
        "rules": {
            "recommended": false,
            "style": {
                "useEnumInitializers": "error"
            }
        }
    },
    "overrides": [
        {
            "include": ["*.ts", "*.tsx"],
            "linter": {
                "rules": {
                    "style": {
                        "useEnumInitializers": "off"
                    }
                }
            }
        }
    ]
}

VSCode config:

{
    "[typescript]": {
        "editor.codeActionsOnSave": {
            "quickfix.biome": "explicit",
        }
    }
}

TypeScript file test.ts:

enum X {
    A,
    B,
}

Expected behavior

The file is saved without modification.

Does this issue occur when using the CLI directly?

No

Logs

No response

[ematipico]

Is the configuration file in the root directory of your project? Does the CLI give you the same result?

[ska-kialo]

Yes, the config file is at the root directory. The CLI ignores the rule for the files specified in overrides as expected.

[nhedger]

I'm able to reproduce the issue.

• CLI does not report anything, as expected
• LSP runs the rule, even though the overrides disable it

[Trace - 09:55:55] Received response 'textDocument/codeAction - (37)' in 3ms.
Result: [
    {
        "title": "Initialize all enum members.",
        "kind": "quickfix.biome.style.useEnumInitializers",
        "edit": {
            "changes": {
                "file:///Users/nicolas/code/repro/index.ts": [
                    {
                        "range": {
                            "start": {
                                "line": 1,
                                "character": 5
                            },
                            "end": {
                                "line": 1,
                                "character": 5
                            }
                        },
                        "newText": " = 0"
                    },
                    {
                        "range": {
                            "start": {
                                "line": 2,
                                "character": 5
                            },
                            "end": {
                                "line": 2,
                                "character": 5
                            }
                        },
                        "newText": " = 1"
                    }
                ]
            }
        },
        "isPreferred": true
    }
]

I'm moving this to the main repo, because this is most likely an LSP issue.