Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Implement function-linear-gradient-no-nonstandard-direction #2808

Closed
Tracked by #2511
togami2864 opened this issue May 10, 2024 · 4 comments · Fixed by #2911
Closed
Tracked by #2511

📎 Implement function-linear-gradient-no-nonstandard-direction #2808

togami2864 opened this issue May 10, 2024 · 4 comments · Fixed by #2911
Assignees
@mdm317
Labels
A-Analyzer Area: analyzer A-Linter Area: linter L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@togami2864
Copy link
Contributor

togami2864 commented May 10, 2024 •
edited
Loading

Description

Implement function-linear-gradient-no-nonstandard-direction

Important

  • Please skip implementing options for now since we will evaluate users actually want them later.
  • Please ignore handling extended CSS language cases such as sass and less.
  • Please skip custom function since we haven't syntax model yet.

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.
@togami2864 togami2864 mentioned this issue May 10, 2024
Open
34 tasks
@togami2864 togami2864 added S-Help-wanted Status: you're familiar with the code base and want to help the project A-Linter Area: linter L-CSS Language: CSS A-Analyzer Area: analyzer labels May 10, 2024
@mdm317
Copy link
Contributor

mdm317 commented May 13, 2024

Can i try this?

@ematipico
Copy link
Member

@togami2864 what's the suggested name for this rule? Can you give us some directions?

@togami2864
Copy link
Contributor Author

How about noInvalidDirectionInLinearGradient??

@Mouvedia
Copy link

If you are changing the rules' names keep an alias to the original name and choose something consistent.
see #2511 (comment)

@mdm317 mdm317 mentioned this issue May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdm317 mdm317

Labels
A-Analyzer Area: analyzer A-Linter Area: linter L-CSS Language: CSS S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(biome_css_analyzer): implement function-linear-gradient-no-nonstandard-direction mdm317/biome
4 participants
@Mouvedia @ematipico @togami2864 @mdm317