-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lint): add no-head-element
from eslint-plugin-next
#4136
Merged
+271
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
Area: CLI
A-Project
Area: project
A-Linter
Area: linter
L-JavaScript
Language: JavaScript and super languages
A-Diagnostic
Area: diagnostocis
labels
Sep 30, 2024
ematipico
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some important changes to address:
- the name of the rule
- the documentation
- the diagnostic
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/no_next_head_element.rs
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #4136 will improve performances by 56.68%Comparing Summary
Benchmarks breakdown
|
kaioduarte
force-pushed
the
no-next-head-element
branch
from
September 30, 2024 18:21
2dc881b
to
f49609e
Compare
ematipico
approved these changes
Oct 1, 2024
togami2864
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-CLI
Area: CLI
A-Diagnostic
Area: diagnostocis
A-Linter
Area: linter
A-Project
Area: project
L-JavaScript
Language: JavaScript and super languages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement no-head-element from
eslint-plugin-next
.I'm willing to port the other rules if they're relevant to the project.
Test Plan
Snapshots + CI