Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): add no-head-element from eslint-plugin-next #4136

Merged
merged 8 commits into from
Oct 5, 2024

Conversation

kaioduarte
Copy link
Contributor

Summary

Implement no-head-element from eslint-plugin-next.

I'm willing to port the other rules if they're relevant to the project.

Test Plan

Snapshots + CI

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Sep 30, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some important changes to address:

  • the name of the rule
  • the documentation
  • the diagnostic

Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #4136 will improve performances by 56.68%

Comparing kaioduarte:no-next-head-element (83b0490) with main (7e29f06)

Summary

⚡ 2 improvements
✅ 103 untouched benchmarks

Benchmarks breakdown

Benchmark main kaioduarte:no-next-head-element Change
big5-added_15586211152145260264.json[uncached] 857.7 µs 547.4 µs +56.68%
db_17847247775464589309.json[cached] 14 ms 12.8 ms +9.77%

@togami2864 togami2864 merged commit 35bb699 into biomejs:main Oct 5, 2024
12 checks passed
@kaioduarte kaioduarte deleted the no-next-head-element branch October 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants