Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useArrowFunction): preserve directives in the code fix #4534

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(useArrowFunction): preserve directives in the code fix #4534

merged 1 commit into from
Nov 14, 2024

Conversation

Conaclos
Copy link
Member

Summary

Fix #4530

Test Plan

I added a test.

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Changelog Area: changelog labels Nov 14, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #4534 will not alter performance

Comparing conaclos/useArrowFunction-directives (e442a93) with main (6d75a4c)

Summary

✅ 99 untouched benchmarks

@Conaclos Conaclos merged commit 9f3e298 into main Nov 14, 2024
12 checks passed
@Conaclos Conaclos deleted the conaclos/useArrowFunction-directives branch November 14, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

Assignees
No one assigned
Labels
A-Changelog Area: changelog A-Linter Area: linter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Function to arrow function conversion removes 'use something' directive
2 participants
@Conaclos @arendjr