Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use biome-ignore-all for top level suppressions #4548

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

ematipico
Copy link
Member

Summary

Closes #4305

As requested by @arendjr , this PR uses the biome-ignore-all for a top-level suppression.

I also took the liberty to provide a very good diagnostic in case the biome-ignore-all, and because of that I had to add more information returned by the function that parses the suppression comments.

Test Plan

Updated the snapshots, the tests and the changeset

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Linter Area: linter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis labels Nov 15, 2024
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

crates/biome_analyze/src/lib.rs Outdated Show resolved Hide resolved
crates/biome_analyze/src/lib.rs Show resolved Hide resolved
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #4548 will not alter performance

Comparing refactor/suppression-all (8edbe73) with next (0476bc7)

Summary

✅ 99 untouched benchmarks

@ematipico ematipico merged commit 24ab360 into next Nov 18, 2024
9 of 11 checks passed
@ematipico ematipico deleted the refactor/suppression-all branch November 18, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Linter Area: linter L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants