Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact generics #1610

Merged
merged 3 commits into from
Jul 26, 2018
Merged

Refact generics #1610

merged 3 commits into from
Jul 26, 2018

Conversation

ManfredKarrer
Copy link
Member

Use generics for type safety at ComboBoxes and ListViews in Formbuilder.

Depends on:
bisq-network/bisq-common#31
bisq-network/bisq-core#139

sqrrm
sqrrm approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Would be good if @ripcurlx could have a proper look as well though.

ripcurlx
ripcurlx approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Looks fine from my point of view

@ManfredKarrer ManfredKarrer merged commit 1755388 into bisq-network:master Jul 26, 2018
@ManfredKarrer ManfredKarrer deleted the refact-generics branch August 14, 2018 19:00
@ripcurlx ripcurlx mentioned this pull request Aug 30, 2018
Closed
@ManfredKarrer ManfredKarrer mentioned this pull request Aug 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManfredKarrer @ripcurlx @sqrrm