Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade Step 1: Add "click here to buy BSQ" link next to trade fee selector #4579

Closed
cd2357 opened this issue Sep 30, 2020 · 14 comments · Fixed by #5055
Closed

Trade Step 1: Add "click here to buy BSQ" link next to trade fee selector #4579

cd2357 opened this issue Sep 30, 2020 · 14 comments · Fixed by #5055

Comments

@cd2357
Copy link
Contributor

cd2357 commented Sep 30, 2020

In step 1 of a trade, both the maker and the taker have to choose how they pay for the trade fee: in BTC or BSQ.

Most people don't know what BSQ is or where they can get it, especially new users. They probably assume that, since they don't already have any BSQ, they can't choose that option.

Therefore, Bisq should add a link to the BSQ market next to the BTC/BSQ fee selector, like this:

Screenshot 2020-09-30 at 09 48 11

Clicking that link should open the "SELL BTC" view, with the BSQ currency pre-selected.

@davidlevinwork
Copy link

davidlevinwork commented Oct 6, 2020

This issue is still open?
I can take crae of it

How do i get to this specific loaction?

@cd2357
Copy link
Contributor Author

cd2357 commented Oct 6, 2020

Yes it's still open, you can take it.

For how to get to the location, see how it's done in similar components (for example, in the Market view under the chart, the "Buy BTC" and "Sell BTC" buttons will redirect the UI to those views).

@davidlevinwork
Copy link

OK, you can assign me?

@ripcurlx
Copy link
Contributor

ripcurlx commented Oct 7, 2020

@pedromvpg Could you please come up with a design for it, so it matches the rest of the UI?

@cd2357
Copy link
Contributor Author

cd2357 commented Oct 12, 2020

Marking it as high prio, since it would improve BSQ liquidity.

@cd2357
Copy link
Contributor Author

cd2357 commented Oct 12, 2020

@davidlevinwork any progress so far? Did you face any issues, or do you have any open questions?

@pedromvpg
Copy link
Member

This is a great idea.
I think the premiss of what @cd2357 proposed is great. I would consider to make the copy as short as possible.
Adding an option that has a little more of a flashy button that calls more attention to itself.

Should we also consider an overlay to explain and entice users to use BSQ?
What do you think? Too transactional?

https://www.figma.com/proto/Lmpb1dwCMVByxhsjk7S4Zf/Buy-BSQ-CTA?node-id=1%3A4&scaling=min-zoom

_Overview

Option A - Dark
Option A - Light
Option B - Dark
Option B - Light
Option C - Dark 1
Option C - Dark 2 Overlay
Option C - Light 1
Option C - Light 2 Overlay

@pedromvpg
Copy link
Member

Any thoughts on this @cd2357 @ripcurlx ?

@cd2357
Copy link
Contributor Author

cd2357 commented Oct 23, 2020

The "Buy BSQ / Learn more" option looks good, but might be overwhelming for new first-time contributors.

So I would suggest the simpler option (with only the "Buy BSQ" button, as you showed it).

@ripcurlx
Copy link
Contributor

I'm also for the simple green BUY BSQ button with the additional information popup.

Screenshot

@chimp1984
Copy link
Contributor

chimp1984 commented Dec 28, 2020

Anyone working on that? Would be nice to get that in for next release.

@Jakub-CZ
Copy link
Contributor

Anyone working on that? Would be nice to get that in for next release.

I'd like to give it a go. Lately, I've been looking into some simpler GUI-related issues to learn the code base, and I think I'm ready for this one now.

@cd2357
Copy link
Contributor Author

cd2357 commented Dec 29, 2020

Go ahead @Jakub-CZ 👍

@Jakub-CZ
Copy link
Contributor

Jakub-CZ commented Jan 5, 2021

I've opened my PR as a draft for now, as I've been struggling with some strange behavior in the UI when we switch from one tab to another, especially from CREATE OFFER (under SELL BTC) to SELL BITCOIN.

Feel free to provide feedback. Hints about what to do with the outstanding UI bug would be most welcome 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants