.Values.*.*DbUrl
s should be incorporated into chaingraph-secrets
#54
Labels
good first issue
Good for newcomers
Instead of just dropping the values of
.Values.hasura.overrideDbUrl
,.Values.hasura.metadataDbUrl
, and.Values.postgres.externalDbUrl
directly into environment variables, those environment variables should be set from thechaingraph-secrets
object likepostgresConnectionString
. This ensures that other systems never unintentionally leak the connection information. (Secrets don't get automatically logged or displayed in many places, simple environment variables do.)E.g. see difference in treatment here:
chaingraph/charts/chaingraph/templates/hasura.yaml
Lines 23 to 57 in ee3c284
And the chart documentation will also need to be updated to better explain how to add/modify those values.
The text was updated successfully, but these errors were encountered: