Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove punct normalizer? #2

Open
ZJaume opened this issue Jul 10, 2023 · 0 comments
Open

Remove punct normalizer? #2

ZJaume opened this issue Jul 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ZJaume
Copy link
Member

ZJaume commented Jul 10, 2023 •
edited
Loading

We are using Moses punct normalizer for scoring here and it is taking 60% of the scoring process. It is there because in the SMT times, we were aplying it to everything, but maybe for this scenario it doesn't affect too much. Or, if we still want to normalize punctuation in order to reduce unks, could we make a much faster implementation regex based? Right now feels like a high time cost compared to the benefits that is giving.
@ZJaume ZJaume added the enhancement New feature or request label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ZJaume