Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] Why bitnami chart allows to modify number of replicas for external dns when external dns does not support multiple replicas #26682

Closed
mzeeshan1 opened this issue Jun 4, 2024 · 1 comment · Fixed by #26759
Assignees
Labels
external-dns solved tech-issues The user has a technical issue about an application

Comments

@mzeeshan1
Copy link

mzeeshan1 commented Jun 4, 2024

Name and Version

bitnami/external-dns

What architecture are you using?

None

What steps will reproduce the bug?

Bitnami external chart allows to configure number of replicas for external dns when external dns does not support multiple replicas
ref: kubernetes-sigs/external-dns#2430
This impacts multiple things in chart

  • Daemonset should not be there
  • Pod Disruption Budget should not be enabled by default.
  • Deployment strategy. It should be Recreate by default if I am not missing anything.

What do you see instead?

The chart allows to modify number of replicas for external DNS it also allows to deploy external DNS as a daemonset

@mzeeshan1 mzeeshan1 added the tech-issues The user has a technical issue about an application label Jun 4, 2024
@github-actions github-actions bot added the triage Triage is needed label Jun 4, 2024
@javsalgar javsalgar changed the title Why bitnami chart allows to modify number of replicas for external dns when external dns does not support multiple replicas https://github.com/kubernetes-sigs/external-dns/issues/2430 [bitnami/external-dns] Why bitnami chart allows to modify number of replicas for external dns when external dns does not support multiple replicas https://github.com/kubernetes-sigs/external-dns/issues/2430 Jun 5, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jun 5, 2024
@github-actions github-actions bot assigned migruiz4 and unassigned javsalgar Jun 5, 2024
@migruiz4 migruiz4 changed the title [bitnami/external-dns] Why bitnami chart allows to modify number of replicas for external dns when external dns does not support multiple replicas https://github.com/kubernetes-sigs/external-dns/issues/2430 [bitnami/external-dns] Why bitnami chart allows to modify number of replicas for external dns when external dns does not support multiple replicas Jun 5, 2024
@migruiz4
Copy link
Member

migruiz4 commented Jun 5, 2024

Thank you for reporting this issue @mzeeshan1.

After some further investigation, looks like indeed external-dns does not officially support having multiple replicas, and doing so could lead to problems.

Because of that, I have submitted #26759, a new major release dropping support for Daemonset and multi-replica deployments. If in a future release external-dns adds support for multiple replicas, we will restore these features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns solved tech-issues The user has a technical issue about an application
Projects
None yet
3 participants