Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] Thanos ruler don't support TLS on grpc #29458

Closed
mcantinqc opened this issue Sep 16, 2024 · 3 comments
Closed

[bitnami/thanos] Thanos ruler don't support TLS on grpc #29458

mcantinqc opened this issue Sep 16, 2024 · 3 comments
Assignees
Labels
solved stale 15 days without activity tech-issues The user has a technical issue about an application thanos triage Triage is needed

Comments

@mcantinqc
Copy link

Name and Version

thanos 0.36.1

What architecture are you using?

amd64

What steps will reproduce the bug?

The querier can be configured to use TLS for GRPC client connections by adding the following configuration:

query:
  enabled: true
  grpc:
    client:
      tls:
        enabled: true
        autoGenerated: true

This configuration forces the querier to use TLS when calling GRPC endpoints.
However, there is currently no way to activate a similar TLS configuration for the ruler component.
For comparison, the storegateway component allows TLS configuration for its GRPC server using the following settings:

storegateway:
  enabled: true
  grpc:
    server:
      tls:
        enabled: true
        autoGenerated: true

The issue is that we need a way to enable TLS for GRPC connections on the ruler component, similar to how it's implemented for the querier and storegateway.

Are you using any custom parameters or values?

No response

What is the expected behavior?

GRPC TLS setup for ruler like for storegateway.

What do you see instead?

dialing connection: context deadline exceeded: connection error: desc = "transport: authentication handshake failed: tls: first record does not look like a TLS handshake

Additional information

Arguments like grpc-server-tls-cert, grpc-server-tls-client-ca and grpc-server-tls-key are fully supported by Thanos ruler : https://thanos.io/tip/components/rule.md/#flags.

@mcantinqc mcantinqc added the tech-issues The user has a technical issue about an application label Sep 16, 2024
@github-actions github-actions bot added the triage Triage is needed label Sep 16, 2024
@javsalgar javsalgar changed the title Thanos ruler don't support TLS on grpc [bitnami/thanos] Thanos ruler don't support TLS on grpc Sep 17, 2024
@javsalgar
Copy link
Contributor

Hi!

Thank you so much for the feature request. I will forward it to the team but as it is not a critical feature we cannot guarantee an ETA. If you want to speed up the process, you can submit a PR updating the args section of the Ruler statefulset

Copy link

github-actions bot commented Oct 3, 2024

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Oct 3, 2024
Copy link

github-actions bot commented Oct 8, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot added the solved label Oct 8, 2024
@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved stale 15 days without activity tech-issues The user has a technical issue about an application thanos triage Triage is needed
Projects
None yet
Development

No branches or pull requests

3 participants