Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail reason to proposal object #730

Closed
2 tasks
abitmore opened this issue Mar 16, 2018 · 6 comments
Closed
2 tasks

Add fail reason to proposal object #730

abitmore opened this issue Mar 16, 2018 · 6 comments
Assignees
Labels

Comments

@abitmore
Copy link
Member

abitmore commented Mar 16, 2018

For better UX, we can add a new field in proposal_object to indicate why a proposal had failed to execute.

  • this feature
  • after done, submit an issue to bitshares-ui repository to use this feature
@abitmore abitmore added this to the Future Non-Consensus-Changing Release milestone Mar 16, 2018
@abitmore abitmore modified the milestones: Future Non-Consensus-Changing Release, 201805 - Non-Consensus-Changing Release Apr 28, 2018
@abitmore
Copy link
Member Author

Just a note: @xeroc is working on this.

@xeroc
Copy link
Member

xeroc commented May 16, 2018

The problem with this ticket is that proposals are only in the database as long as they are not expired or executed. That lead us to implement a plugin for persistent proposals (for PeerPlays specifically). This plugin is currently extended to also handle exceptions.
However, as I discussed with @pmconrad yesterday, the plugin can not nicely deal with roll-backs or nested proposals.

@abitmore
Copy link
Member Author

@xeroc persistent proposal is another topic which is out of scope of this issue. In this issue we'll focus on active proposals but not expired ones.

OP is clear: add a new field in proposal_object to indicate why a proposal had failed to execute. If you're going this way, please proceed; otherwise please unassign yourself or leave a message so others will know to work on it.

@abitmore abitmore modified the milestones: 201806 - Non-Consensus-Changing Release, 201807 - Next Non-Consensus-Changing Release May 21, 2018
@xeroc xeroc removed their assignment May 28, 2018
@xeroc
Copy link
Member

xeroc commented May 28, 2018

I have unassigned myself.

@ryanRfox
Copy link
Contributor

@jmjatlanta I believe that because this is merged it should be marked Closed as well. I'll allow you to do that when appropriate. Thank you for moving to Done. In the future, you may automate this: https://blog.github.com/2013-05-14-closing-issues-via-pull-requests/

@jmjatlanta
Copy link
Contributor

Learn something new every day. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants