Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Menu Autofill Not Working (iOS 18) #916

Open
2 tasks done
zoltrons opened this issue Sep 11, 2024 · 6 comments
Open
2 tasks done

Context Menu Autofill Not Working (iOS 18) #916

zoltrons opened this issue Sep 11, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@zoltrons
Copy link

zoltrons commented Sep 11, 2024

Bitwarden Beta

  • I'm using the new native Bitwarden Beta app and I'm aware that legacy .NET app bugs should be reported in bitwarden/mobile

Steps To Reproduce

  1. Go to 'any app with text field'
  2. Tap on 'text field twice'
  3. Press to 'autofill'
  4. Tap on 'passwords'

Expected Result

Opening the autofill menu

Actual Result

AutoFill Unavailable
The developer of "Bitwarden" needs to update it to work with this feature. You can open "Bitwarden" to copy information to fill.

Screenshots or Videos

video.mp4

Additional Context

I think apple finally open up autofill context menu button for third-party apps with iOS 18. So an implementation need for this feature.

Build Version

2024.8.1 (1052)

Environment Details

Device: iPhone 15
OS: iOS 18 RC

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@zoltrons zoltrons added the bug Something isn't working label Sep 11, 2024
@jtodddd
Copy link

jtodddd commented Sep 12, 2024

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

@zoltrons
Copy link
Author

Hi there,

I am unable to reproduce this issue, it has been escalated for further investigation. If you have more information that can help us, please add it below.

Thanks!

Are you tried on iOS 18? And in os settings, only password manager enabled is bitwarden?

@zoltrons
Copy link
Author

zoltrons commented Sep 19, 2024

More people reporting the issue on Reddit.
https://www.reddit.com/r/Bitwarden/comments/1fiy4m4/autofill_by_long_pressing_text_field_in_ios_18_is/

The new feature is mentioned in this video, around 9 min 33 sec.
https://developer.apple.com/videos/play/wwdc2024/10125/

@lcasale
Copy link

lcasale commented Sep 21, 2024

Having the same issue on public release iOS 18. In prior iOS releases it wouldn't even load Bitwarden from the context menu but at least gives this error in iOS 18.

trim.ACB999C1-84D6-4C09-9B00-2ACE74FB28E5.MOV

image

@aneutron
Copy link

aneutron commented Sep 23, 2024

I have the same issue, I have tried the following:

  • First, reboot the device.
  • Then disable autofill for Bitwarden and Re-enable it.
  • Then disable and re-enable the whole autofill feature.
  • Reinstall the app and try the 3 above scenarios.

Still no luck.

Versions:

  • iOS 18.0 (22A3354, EU build if that helps)
  • 2024.9.1 (1092)

@jmalexan
Copy link

jmalexan commented Oct 28, 2024

I was looking into this this morning to see if this functionality could be implemented easily, but I realized there's some UI work that would be required that's above my pay grade as someone who's not looked at this codebase before. Here's what I dug up though, in case it helps the next person:

  • This key needs to be added to the appropriate dictionary in the plist
  • This function needs to be implemented in BitwardenAutoFillExtension/CredentialProviderViewController.swift
  • UI needs to be added to the pop-up vault list that allows for drilling into a vault item's details and selecting the specific thing to autofill from that item (at the very least should allow selecting between username and password, but ideally would allow selecting any text field in a vault item).
  • Needs to call this function to pass the text value back to the system, instead of this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants