PM-11883: Improve handling of biometric unlock errors #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-livefront
requested review from
fedemkr,
phil-livefront and
KatherineInCode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
+ Coverage 88.54% 88.56% +0.01%
==========================================
Files 617 617
Lines 38918 38921 +3
==========================================
+ Hits 34461 34469 +8
+ Misses 4457 4452 -5 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
fedemkr
approved these changes
Sep 11, 2024
KatherineInCode
approved these changes
Sep 11, 2024
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11883
📔 Objective
This improves the handling of errors during Face ID unlock to hopefully fix the issue of Face ID being deactivated due to any errors other than the auth key not being found.
BiometricsServiceError.getAuthKeyFailedwas being thrown for any unhandled errors, but this is also used to determine if Face ID should be deactivated if the auth key doesn't exist. This also adds error logging to Crashlytics for thegetAuthKeyFailedand other errors to give more context if this doesn't solve the issue.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes