Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting variables of built-in types to null is impossible when adding type hints #339

Closed
bitwes opened this issue Jan 15, 2022 · 2 comments
Labels
Godot 4.0 Issues related to Godot 4.0

Comments

@bitwes
Copy link
Owner

bitwes commented Jan 15, 2022

Setting variables of built-in types to null is impossible when adding type hints, and sometimes marked as an error otherwise.

So maybe it is worth to think of other ways of indicating "no value yet", or lobby for the nullable? types proposal that's on godot-proposals.

@strank
Copy link
Contributor

strank commented Feb 15, 2022

Hi @bitwes I do have a 4.0 branch now that at least allows you to run the whole test suite on the command line. See https://github.com/strank/Gut/tree/4.0 The current end result, running with godot built from this branch https://github.com/strank/godot/tree/gut-porting-to-godot4 (which has two fixes not yet in main Godot), is:

Totals
Scripts:          40
Passing tests     1036
Failing tests     85
Pending:          4
Asserts:          1419/119

Warnings/Errors:
* 21 Errors.
* 122 Warnings.
* 5 Deprecated calls.


1036 passed 85 failed.  Tests finished in 108.0s

versus on Godot 3.4.2 (with Gut a few commits behind):

Totals
Scripts:          40
Passing tests     1079
Failing tests     9
Pending:          4
Asserts:          1528/16

Warnings/Errors:
* 17 Errors.
* 6 Warnings.


1079 passed 9 failed.  Tests finished in 97.4s

Hope that helps in some way :)

@bitwes
Copy link
Owner Author

bitwes commented Mar 3, 2023

I believe this is not an issue any longer.

@bitwes bitwes closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Godot 4.0 Issues related to Godot 4.0
Projects
None yet
Development

No branches or pull requests

2 participants