Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent default description tag to be inserted into HTML if not updated #35

Open
kuanb opened this issue Jul 20, 2017 · 2 comments
Open

Comments

@kuanb
Copy link

kuanb commented Jul 20, 2017

I don't use this tool or Expression Engine CMS but wanted to note that I was c/p a link into Slack today from these guys: http://mrcagney.com/

And the description was bizarre:

<meta name='keywords' content='your, default, keywords, here' />
<meta name='description' content='Your default description here' />

Inspecting the HTML, I saw the tag that noted the above was created b/c of this SEO Lite add on. Perhaps it would be ideal if the add on did not insert these meta tags if the user has not updated the values associated with each.

@bjornbjorn
Copy link
Owner

Hi kuanb,

thanks for your input.

These are the default values you get when installing SEO Lite. Most people will change those values on install, but if they don't it will look like what you pasted. I guess a solution could be to have empty values on install, that way it would look like this:

<meta name='keywords' content='' />
<meta name='description' content='' />

.. but then I might get more support requests asking why keywords / descriptions are empty (on the frontpage etc). The way they are today they sort of push you to go and investigate and then discover the settings in the backend.

Or maybe just write it out like this:

<meta name='keywords' content='Please edit the default keywords setting in SEO Lite' />
<meta name='description' content='Please edit the default description setting in SEO Lite' />

🤔

@kuanb
Copy link
Author

kuanb commented Jul 21, 2017

Yeah sorry I can't be of more help. I'm not sure what your plug in does. If it's a GUI over html perhaps dynamically converting those segments to empty quotes during a build step would work?

Downside is the more obvious you make the default text in the current set up, the more ridiculous it will be when someone doesn't update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants