Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to toml_edit from toml-rs #25

Closed
Shatur opened this issue Aug 13, 2022 · 3 comments · Fixed by #29
Closed

Switch to toml_edit from toml-rs #25

Shatur opened this issue Aug 13, 2022 · 3 comments · Fixed by #29

Comments

@Shatur
Copy link
Contributor

Shatur commented Aug 13, 2022

What problem does this solve or what need does it fill?

toml-rs is unmaintained and it's a TOML 0.5 compliant parser.

What solution would you like?

It would be nice to use toml_edit. It's a drop-in replacement, actively maintained and supports TOML 1.0. For example, Cargo now use it.
@Shatur
Copy link
Contributor Author

Shatur commented Jan 22, 2023 •
edited
Loading

toml-rs was archived. @bkchr are you interested in this change? I could send a PR. It's basically a drop-in replacement.

@bkchr
Copy link
Owner

bkchr commented Jan 22, 2023

Yes! Sorry for having overseen this!

@Shatur Shatur mentioned this issue Jan 23, 2023
Merged
@Shatur
Copy link
Contributor Author

Shatur commented Jan 23, 2023

@bkchr opened #29.

@bkchr bkchr closed this as completed in #29 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to toml_edit
2 participants
@bkchr @Shatur