Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumenter #137

Merged
merged 7 commits into from
Oct 18, 2014
Merged

Add instrumenter #137

merged 7 commits into from
Oct 18, 2014

Conversation

bkeepers
Copy link
Owner

@bkeepers bkeepers commented Oct 3, 2014

This adds support for instrumentation so code can be notified when dotenv files are loaded.
#118 will only watch .env. If an app loads other files, they won't be watched by spring. This fixes that by subscribing to the dotenv events.

/cc @jnunemaker

bkeepers referenced this pull request Oct 4, 2014
Watch .env for changes with Spring in Rails 4
@jnunemaker
Copy link

Makes sense to me.

* origin/master:
  Release 1.0.2
  Override .load class method to avoid calling Kernel#load
  Exclude rails files from dotenv gem
  Update change log with `Dotenv::Railtie.load` and `dotenv/rails-now`
  Note load order considerations in REAME
  Add dotenv/rails-now to load dotenv immediately
  Rename "dotenv/railtie" to "dotenv/rails"
  Define Dotenv::Railtie.load
  specs for railtie
  Prepare for 1.0.1 release
  Attempt to load spring/watcher
  Remove jruby from travis until error is resolved
  Use before_configuration callback to load config
  update changelog
  Bump version
  Update changelog for 1.0
  Clarify stance on committing .env
  Remove dotenv-deployment dependency
  Remove deprecations

Conflicts:
	lib/dotenv-rails.rb
bkeepers added a commit that referenced this pull request Oct 18, 2014
@bkeepers bkeepers merged commit 1698dfc into master Oct 18, 2014
@bkeepers bkeepers deleted the instrumentation branch October 18, 2014 13:27
sheax0r pushed a commit to sheax0r/dotenv that referenced this pull request Sep 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants