Handle thread safety for Dotenv.restore, Add Dotenv.modify #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with #472 when running Rails tests with
parallelize
. SinceENV
is global state, modifications are not thread safe. This will raise an error if callingDotenv.restore
outside ofThread.main
, and addsDotenv.modify
for a threadsafe way to modifyENV
.Note that the block passed to
#modify
is synchronized in a semaphore, so threads calling it will execute serially.This PR also refactors
Dotenv::Diff
introduced in #473 and uses it to save/restore.