Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Default padding on modal is very small #483

Closed
Blackbaud-JaredCastello opened this issue Mar 13, 2017 · 3 comments
Closed

Default padding on modal is very small #483

Blackbaud-JaredCastello opened this issue Mar 13, 2017 · 3 comments
Assignees
@Blackbaud-PatrickOFriel
Labels
Difficulty: Low Type: Bug
Milestone
Block 2 Sprint 4 ...

Comments

@Blackbaud-JaredCastello
Copy link

Description From Josh Gerdes:
The margin/padding on the current modal is from skyux2. So I’m assuming they are providing the accepted UX patterns for skyux. And will update as skyux UX patterns update.

Expected behavior

More padding for modals based on accepted UX patterns

Actual behavior

Default padding on modal is very small

Steps to reproduce

image
@Blackbaud-PatrickOFriel
Copy link
Contributor

Yeah looks like in SKY UX 1 the modal body padding was 15, and in SKY UX 2 we have the content padding at 10. I'm assuming we should bump it up to 15px, @Blackbaud-ToddRoberts ?

@Blackbaud-ToddRoberts
Copy link
Contributor

Yes it should be updated to match the 15px in SkyUX 1.

Merged
@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-beta.14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Blackbaud-PatrickOFriel Blackbaud-PatrickOFriel

Labels
Difficulty: Low Type: Bug
Projects
None yet
Milestone
Block 2 Sprint 4 - 3/24/2017
Development

No branches or pull requests
3 participants
@Blackbaud-PatrickOFriel @Blackbaud-ToddRoberts @Blackbaud-JaredCastello