Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Need ability to specify size of modal #489

Closed
Blackbaud-ScottFreeman opened this issue Mar 15, 2017 · 7 comments
Closed

Need ability to specify size of modal #489

Blackbaud-ScottFreeman opened this issue Mar 15, 2017 · 7 comments

Comments

@Blackbaud-ScottFreeman
Copy link
Contributor

Expected behavior

SkyUX1 allows you to specify the size through the uibModalOptions of bbModal.open. The size can be specified by using a string of "sm" or "lg" that gets appended to the "modal-" css class used to size the modal. I would expect something similar where we specify more of a conceptual size instead of actual pixels so that modals will have a consistent look and work well with responsive designs.

Actual behavior

There doesn't currently appear to be a way to resize unless you override skyux css.

@blackbaud-danbowman
Copy link

@Blackbaud-ToddRoberts can you provide design guidance on this one?

@blackbaud-danbowman
Copy link

Speaking for @Blackbaud-ToddRoberts...two options - small & large

@Blackbaud-AdamHickey
Copy link
Contributor

@Blackbaud-ToddRoberts Do you know the specific sizes for the small and large options?

@Blackbaud-AdamHickey
Copy link
Contributor

@Blackbaud-ToddRoberts
Copy link
Contributor

I think the safest approach is to have sm (300px) md (600px) and lg (900px) like bootstrap does, with md being the default.

@Blackbaud-PatrickOFriel
Copy link
Contributor

Hey @Blackbaud-ScottFreeman, we have a pending pull request for this work, but we need to come up with guidelines for when to use each modal size. Can you get your design to contact @Blackbaud-ToddRoberts so we can get some use-cases? Thanks!

@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-beta.31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants