Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken with SublimeText 4 ? #25

Closed
tfrancart opened this issue May 25, 2021 · 12 comments
Closed

Broken with SublimeText 4 ? #25

tfrancart opened this issue May 25, 2021 · 12 comments

Comments

@tfrancart
Copy link

Ubuntu recently updated my SublimeText package and LinkedData package is not working anymore.
SublimeText build = 4107

Anytthing special I need to do ?
Thanks !

@tfrancart
Copy link
Author

I think it is the macaron-dark theme that is broken

Here is what I see

image

@ncarboni
Copy link

ncarboni commented Jun 3, 2021

same here, back in ST3 works perfectly

@paulwalk
Copy link

I am seeing this problem too. Selecting Preferences / "Color Scheme" / "auto" and then "mariana" seem to be a workaround, but only for the current file. I guess the problem is with the colour scheme.

@griffin-rickle
Copy link

Hey all,

TL;DR the LinkedData package is setting the color_scheme and overriding the global color scheme.

One workaround is going to Settings -> Syntax Specific and setting your color scheme there. However, as rwols pointed out in the ST thread, this package should ideally not be setting a Color Scheme at all. Here's the link:
https://forum.sublimetext.com/t/syntax-highlighting-broken-in-sublime-text-4/59175/15

@blake-regalia
Copy link
Owner

The colors being broken in ST4 is actually due to a bug in ST3 that was initially discovered when I opened an issue here and eventually led to this bug report. Unfortunately it is going to require completely redoing the color schemes for it to look right in ST4. We can keep this issue open until such a fix is implemented for ST4.

As for overriding the syntax settings, this was done intentionally because this package creates super specific scopes and requires special color schemes to work properly, for example see this comment.

@paulwalk
Copy link

One workaround is going to Settings -> Syntax Specific and setting your color scheme there.

Thanks @griffin-rickle - this is a good workaround.

@griffin-rickle
Copy link

griffin-rickle commented Jul 15, 2021

@paulwalk The workaround works for now, but the whole point of the package is subverted; i.e. the granularity of highlighting subject, predicate, and object, datatype specifications, strings vs IRIs, etc with a custom color scheme is nowhere near as good as what you get with the color scheme this repo.

@blake-regalia

As for overriding the syntax settings, this was done intentionally because this package creates super specific scopes and requires special color schemes to work properly, for example see this comment.

You are absolutely correct. I attempted to take a look at the code and stop the forcing of a color scheme, but I see this is not the right way to go about it. I would like to help, but unfortunately I'm very new to the world of Sublime Text color scheme definitions and not a JavaScript coder by any means (that doesn't mean I'm not willing to learn). What's the first step to fixing the issue?

@blake-regalia
Copy link
Owner

Color schemes for ST4 fixed in new release!! v1.0.0 now available for install/update on PackageControl
@tfrancart @paulwalk @griffin-rickle @ncarboni

@tfrancart
Copy link
Author

Alleluïa, updated ST4 Ubuntu package, and Turtle syntax highlight is back to normal. You made my day !

@griffin-rickle
Copy link

Color schemes for ST4 fixed in new release!! v1.0.0 now available for install/update on PackageControl
@tfrancart @paulwalk @griffin-rickle @ncarboni

Most excellent. Works perfectly again. Thank you!

@paulwalk
Copy link

paulwalk commented Sep 7, 2021

confirmed - working perfectly now - thanks!

@ncarboni
Copy link

ncarboni commented Sep 7, 2021

works great for me too! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants