Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly named testfiles #284

Open
ghost opened this issue Sep 13, 2019 · 0 comments
Open

Incorrectly named testfiles #284

ghost opened this issue Sep 13, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 13, 2019

Describe the bug

I'm seeing some inconsistencies with the names of some of the test files. Documenting it now to investigate later.

https://github.com/blockchain-certificates/cert-verifier-js/blob/master/test/fixtures/mainnet-invalid-merkle-receipt-2.0.json : says mainnet but checks against bitcoin testnet. There is no chain specified in the certificate.

https://github.com/blockchain-certificates/cert-verifier-js/blob/master/test/fixtures/mainnet-merkle-root-unmatch-2.0.json : says mainnet but checks against bitcoin testnet. There is no chain specified in the certificate.

https://raw.githubusercontent.com/blockchain-certificates/cert-verifier-js/master/test/fixtures/mainnet-revoked-2.0.json : says mainnet but checks against bitcoin testnet. There is no chain specified in the certificate.

https://raw.githubusercontent.com/blockchain-certificates/cert-verifier-js/master/test/fixtures/mainnet-valid-2.0-alpha.json : says mainnet but checks against bitcoin testnet. There is no chain specified in the certificate.

https://raw.githubusercontent.com/blockchain-certificates/cert-verifier-js/master/test/fixtures/testnet-404-issuer-url-1.2.json : says testnet but checks against bitcoin mainnet. There is no chain specified in the certificate.

To Reproduce
Steps to reproduce the behavior:

  1. Put each of these certs into blockcerts.org

Expected behavior

Mainnet files should say/check mainnet, testnet files should say/check testnet.

Additional context

It appears that when chain is not specified, it checks against the address prefix? Not the best logic, but in either case it looks like these files are named incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants