From 8bf14e8149d237850a6a2483401ca26d67031dc8 Mon Sep 17 00:00:00 2001 From: KacperKoza343 <165884432+KacperKoza343@users.noreply.github.com> Date: Tue, 18 Jun 2024 10:27:05 +0200 Subject: [PATCH] Fix/signature (#126) * Updates README.md (#125) * Updates README.md: Adds Caching section, Changes in signature type * README.md updates * README.md updates * fix(app/worker): add signature field to req body * update(app): revert readme * fix(app/register-address): fix test --------- Co-authored-by: macnablocky <143715306+macnablocky@users.noreply.github.com> Co-authored-by: Kacper Koza --- packages/apps/human-app/server/README.md | 2 +- .../register-address/model/register-address.model.ts | 8 ++++++++ .../spec/register-address.controller.spec.ts | 2 +- .../register-address/spec/register-address.fixtures.ts | 4 ++++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/packages/apps/human-app/server/README.md b/packages/apps/human-app/server/README.md index 653ce228f7..fe8e49c347 100644 --- a/packages/apps/human-app/server/README.md +++ b/packages/apps/human-app/server/README.md @@ -82,4 +82,4 @@ the exchange oracle URL as well as responses from the following endpoints: * `/h-captcha/user-stats` * `/oracles` * `/statistics/stats` - * `/statistics/stats/assignment` + * `/statistics/stats/assignment` \ No newline at end of file diff --git a/packages/apps/human-app/server/src/modules/register-address/model/register-address.model.ts b/packages/apps/human-app/server/src/modules/register-address/model/register-address.model.ts index 18924bc8f6..ef18115fcf 100644 --- a/packages/apps/human-app/server/src/modules/register-address/model/register-address.model.ts +++ b/packages/apps/human-app/server/src/modules/register-address/model/register-address.model.ts @@ -7,15 +7,23 @@ export class RegisterAddressDto { @IsString() @ApiProperty({ example: 'string' }) address: string; + @AutoMap() + @IsString() + @ApiProperty({ example: 'string' }) + signature: string; } export class RegisterAddressCommand { @AutoMap() address: string; + @AutoMap() + signature: string; token: string; } export class RegisterAddressData { @AutoMap() address: string; + @AutoMap() + signature: string; } export class RegisterAddressResponse { signed_address: string; diff --git a/packages/apps/human-app/server/src/modules/register-address/spec/register-address.controller.spec.ts b/packages/apps/human-app/server/src/modules/register-address/spec/register-address.controller.spec.ts index 232e2563a2..4748e24a25 100644 --- a/packages/apps/human-app/server/src/modules/register-address/spec/register-address.controller.spec.ts +++ b/packages/apps/human-app/server/src/modules/register-address/spec/register-address.controller.spec.ts @@ -5,13 +5,13 @@ import { HttpService } from '@nestjs/axios'; import { RegisterAddressController } from '../register-address.controller'; import { RegisterAddressService } from '../register-address.service'; import { registerAddressServiceMock } from './register-address.service.mock'; -import { RegisterAddressProfile } from '../register-address-profile.service'; import { REGISTER_ADDRESS_TOKEN, registerAddressCommandFixture, registerAddressDtoFixture, registerAddressResponseFixture, } from './register-address.fixtures'; +import { RegisterAddressProfile } from '../register-address.mapper.profile'; describe('RegisterAddressController', () => { let controller: RegisterAddressController; diff --git a/packages/apps/human-app/server/src/modules/register-address/spec/register-address.fixtures.ts b/packages/apps/human-app/server/src/modules/register-address/spec/register-address.fixtures.ts index 378c041041..52201e41b2 100644 --- a/packages/apps/human-app/server/src/modules/register-address/spec/register-address.fixtures.ts +++ b/packages/apps/human-app/server/src/modules/register-address/spec/register-address.fixtures.ts @@ -5,17 +5,21 @@ import { RegisterAddressResponse, } from '../model/register-address.model'; const ADDRESS = '0xsome_address'; +const SIGNATURE = '0xsome_signature'; export const REGISTER_ADDRESS_TOKEN = 'my_access_token'; const RESPONSE_ADDRESS = 'signed_address_response'; export const registerAddressDtoFixture: RegisterAddressDto = { address: ADDRESS, + signature: SIGNATURE, }; export const registerAddressCommandFixture: RegisterAddressCommand = { address: ADDRESS, token: REGISTER_ADDRESS_TOKEN, + signature: SIGNATURE, }; export const registerAddressDataFixture: RegisterAddressData = { address: ADDRESS, + signature: SIGNATURE, }; export const registerAddressResponseFixture: RegisterAddressResponse = { signed_address: RESPONSE_ADDRESS,