Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAWs are not refreshed correctly for resources on symmetry counterparts when switching variants #215

Open
ChrisAdderley opened this issue Apr 11, 2021 · 1 comment
Labels

Comments

@ChrisAdderley
Copy link

As in the title.

This doesn't seem to occur for all symmetry counterparts but some subset. The resources don't seem to really exist (as measured by looking at ship total mass).

See more detail and reproduction steps here

@ChrisAdderley ChrisAdderley changed the title PAWs are not refreshed correctly for resources when switching variants PAWs are not refreshed correctly for resources on symmetry counterparts when switching variants Apr 11, 2021
@DRVeyl
Copy link

DRVeyl commented Apr 11, 2021

I believe this relates to some PAW caching behaviour, apparently introduced after KSP 1.8. (As in, this is not observed in a 1.8 build, but is in 1.10)
See also KSP-RO/RealFuels#255 and a maybe heavy-handed fix KSP-RO/RealFuels#256

Heavy-handed because this ends up tracking if we would have marked the PAW dirty if it were open, but can't because it is not open.
I think this has to do with updating symmetry counterparts during the onFieldChanged handler, instead of the onSymmetryFieldChanged handler. (onSymmetryFieldChanged has its problems, not suggesting that as a solution.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants