Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Capybara 3.x #45

Open
manuelmeurer opened this issue Apr 12, 2018 · 8 comments
Open

Support for Capybara 3.x #45

manuelmeurer opened this issue Apr 12, 2018 · 8 comments

Comments

@manuelmeurer
Copy link

Hey, thanks for writing this fantastic gem! 😄
Are there any plans to support Capybara v3? I tried simply updating the dependency (und patching minitest-capybara to support Capybara v3 as well) and it worked fine.
If you could point me into the right direction to what would need to be done to support Cabybara v3, I'd be happy to work on it!

@MrHubble
Copy link

I tried simply updating the dependency (und patching minitest-capybara to support Capybara v3 as well) and it worked fine.

Do you have a fork I could use or refer to for how to do this? Thanks.

@jrmhaig
Copy link

jrmhaig commented Apr 13, 2018

Slightly related to this; If you have this in your Gemfile:

gem 'minitest-rails-capybara'
gem 'capybara'

(without specifying versions) and do a bundle update then your version of minitest-rails-capybara will drop down to version 0.0.2, being the most recent version that claims to support any version of capybara. The latest version is pinned to ~> 2.7.

I don't know what the correct solution is here.

@manuelmeurer
Copy link
Author

@jrmhaig That sounds more like an issue with Bundler than with this gem to me.

@MrHubble Sure, here's my fork: https://github.com/krautcomputing/minitest-rails-capybara/tree/2.x_with_capybara_3

@jrmhaig
Copy link

jrmhaig commented Apr 13, 2018

Yes and no. Bundler will try to find the most recent version of all gems that satisfy all dependencies. It is therefore possible, according to the definitions of the gems, to upgrade capybara by downgrading minitest-rails-capybara to 0.0.2. This, I believe, is the correct behaviour for Bundler.

By the way, I hope I am not coming across as being awkward or argumentative. I very much appreciate the work that has gone into this gem and I do not think this is a major problem. However, I thought it was worth pointing out as some users may encounter problems as a result.

@MrHubble
Copy link

Perhaps this gem is no longer actively maintained because Rails 5.1 has system tests (with Capybara) baked in? I believe the author of The Minitest Cookbook uses the default system tests setup:

So far I’m loving this combination of (no) setup and (more) features that system tests provide. If you’ve read about my previous setup based on minitest-rails-capybara in The Minitest Cookbook, let me be clear: this is my new jam, and I’ll be shipping an update to the book sometime after Rails 5.1 officially ships that covers system tests.

https://chriskottom.com/blog/2017/04/full-stack-testing-with-rails-system-tests/

@manuelmeurer
Copy link
Author

Ah, good to know!
I'm stuck with my app on Rails 4.2 for a while, so it would be great to be able to use Capybara v3 with this gem.
@blowmage What do you think?

@CyborgMaster
Copy link

@manuelmeurer, I'm currently using your fork to support capybara 3 with Rails 4.2. Thanks!

@manuelmeurer
Copy link
Author

@CyborgMaster Glad it works for you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants