From 81b65dd841cc4a5e3b1df1f4d0d1a23fd0c4132e Mon Sep 17 00:00:00 2001 From: Justin Traglia <95511699+jtraglia@users.noreply.github.com> Date: Thu, 28 Mar 2024 12:14:22 -0500 Subject: [PATCH] nit: remove unnecessary call to into_u256() for bn128 add (#1239) * nit: remove unnecessary call to into_u256() for bn128 add * Rename out to output --- crates/precompile/src/bn128.rs | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/crates/precompile/src/bn128.rs b/crates/precompile/src/bn128.rs index 6d45240973..49d6d3f654 100644 --- a/crates/precompile/src/bn128.rs +++ b/crates/precompile/src/bn128.rs @@ -145,16 +145,9 @@ pub fn run_add(input: &[u8]) -> Result { let mut output = [0u8; 64]; if let Some(sum) = AffineG1::from_jacobian(p1 + p2) { - sum.x() - .into_u256() - .to_big_endian(&mut output[..32]) - .unwrap(); - sum.y() - .into_u256() - .to_big_endian(&mut output[32..]) - .unwrap(); + sum.x().to_big_endian(&mut output[..32]).unwrap(); + sum.y().to_big_endian(&mut output[32..]).unwrap(); } - Ok(output.into()) } @@ -166,12 +159,12 @@ pub fn run_mul(input: &[u8]) -> Result { // `Fr::from_slice` can only fail when the length is not 32. let fr = bn::Fr::from_slice(&input[64..96]).unwrap(); - let mut out = [0u8; 64]; + let mut output = [0u8; 64]; if let Some(mul) = AffineG1::from_jacobian(p * fr) { - mul.x().to_big_endian(&mut out[..32]).unwrap(); - mul.y().to_big_endian(&mut out[32..]).unwrap(); + mul.x().to_big_endian(&mut output[..32]).unwrap(); + mul.y().to_big_endian(&mut output[32..]).unwrap(); } - Ok(out.into()) + Ok(output.into()) } pub fn run_pair(