Accessing call value and sender in precompiles

[JamesHinshelwood]

Currently only the call data is passed to precompiles:

revm/crates/revm/src/context/context_precompiles.rs

Line 212 in 4d0feec

bytes: &Bytes,

We're working on some custom precompiles that need to know the msg.value and msg.sender too. Would there be any sympathy for adding these parameters to the precompile traits (Perhaps by passing &CallInputs instead)?

[rakita]

That makes sense. Do you want to add it?

[jsvisa]

just curious, the msg.sender and msg.value are already in the Env.tx? Don't hesitate to correct me if I'm misunderstood.

revm/crates/revm/src/context/context_precompiles.rs

Lines 199 to 205 in d38ff45

	fn call(
	&self,
	bytes: &Bytes,
	gas_limit: u64,
	evmctx: &mut InnerEvmContext<DB>,
	) -> PrecompileResult;
	}

revm/crates/primitives/src/env.rs

Lines 535 to 548 in d38ff45

	pub struct TxEnv {
	/// Caller aka Author aka transaction signer.
	pub caller: Address,
	/// The gas limit of the transaction.
	pub gas_limit: u64,
	/// The gas price of the transaction.
	pub gas_price: U256,
	/// The destination of the transaction.
	pub transact_to: TxKind,
	/// The value sent to `transact_to`.
	pub value: U256,
	/// The data of the transaction.
	pub data: Bytes,

[rakita]

just curious, the msg.sender and msg.value are already in the Env.tx? Don't hesitate to correct me if I'm misunderstood.

What I understood is caller and value of a subcall.