Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce timestamp overhead #48

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Reduce timestamp overhead #48

wants to merge 2 commits into from

Conversation

joaoantoniocardoso
Copy link
Member

Closes #26

patrickelectric
patrickelectric reviewed Oct 4, 2024
View reviewed changes
src/protocol.rs

#[inline(always)]
pub fn timestamp_micros() -> u64 {
std::time::SystemTime::now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are doing this, I would vote for avoiding SystemTime and using a monotonic source if possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the monotonic would be std::Instant::now()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick improvement: timestamps
2 participants
@joaoantoniocardoso @patrickelectric