Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common_gui needs extra paraenthesis #734

Closed
wcole3 opened this issue May 6, 2023 · 2 comments
Closed

common_gui needs extra paraenthesis #734

wcole3 opened this issue May 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@wcole3
Copy link

wcole3 commented May 6, 2023

Just a missing set of parenthesis in common_gui.py line 108 for isdigit. If you have an older config file, you can get an error loading it due to the old noise offset default value being noise_offset=''

If you encounter an error like you can manually change the noise offset value to a 0.

Traceback (most recent call last):
  File "D:\StableDiff\kohya_ss\venv\lib\site-packages\gradio\routes.py", line 399, in run_predict
    output = await app.get_blocks().process_api(
  File "D:\StableDiff\kohya_ss\venv\lib\site-packages\gradio\blocks.py", line 1299, in process_api
    result = await self.call_function(
  File "D:\StableDiff\kohya_ss\venv\lib\site-packages\gradio\blocks.py", line 1022, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "D:\StableDiff\kohya_ss\venv\lib\site-packages\anyio\to_thread.py", line 31, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "D:\StableDiff\kohya_ss\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 937, in run_sync_in_worker_thread
    return await future
  File "D:\StableDiff\kohya_ss\venv\lib\site-packages\anyio\_backends\_asyncio.py", line 867, in run
    result = context.run(func, *args)
  File "D:\StableDiff\kohya_ss\lora_gui.py", line 305, in open_configuration
    my_data = update_my_data(my_data)
  File "D:\StableDiff\kohya_ss\library\common_gui.py", line 109, in update_my_data
    my_data[key] = float(value)
ValueError: could not convert string to float: ''
@bmaltais bmaltais added the bug Something isn't working label May 7, 2023
@bmaltais
Copy link
Owner

bmaltais commented May 7, 2023

I will try to fix that at load time, thanks for reporting.

@bmaltais
Copy link
Owner

bmaltais commented May 7, 2023

The latest code in master should now have the fix. Thanks!

@wcole3 wcole3 closed this as completed May 7, 2023
@bmaltais bmaltais mentioned this issue May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants