This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
[fix-bug] image with same URL should not add twice more reliable id image tag fix #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bmaupin @owulveryck i get randomly same error test |
Monirzadeh
changed the title
[fix-bug] image with same URL should not add twice
[fix-bug] image with same URL should not add twice more reliable id
Aug 24, 2023
Monirzadeh
changed the title
[fix-bug] image with same URL should not add twice more reliable id
[fix-bug] image with same URL should not add twice more reliable id image tag fix
Aug 26, 2023
@bmaupin i think it is ready and fix 3 bug
if it is good to you i start update unit test. |
Co-authored-by: Felipe Martin <[email protected]>
Monirzadeh
force-pushed
the
fix-duplicate-image
branch
from
September 16, 2023 08:20
27055cb
to
e57fc62
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmbededImage add same URL how many times it exist in HTML file that make unnecessary big file and some other problem. this PR download and add image to epub just once and reference all of same url image to the same file inside epub.