-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] call to getTransaction on a versioned transaction fail #426
Comments
Added support for versioned transactions. I believe compile message needs a update to write versioned transaction from the client not totally sure so this only covers the reading portion. |
indeed this PR only aim to fix the reading portion for the moment. |
Well looks like this PR only fix the call to getTransaction and getBlock and is finally not enough for the reading portion The transaction format changed so Solnet currently fail to decode the tx because of the table lookup I think. |
eac7430 |
thanks, your implementation is better. I quickly looked at the typescript implementation, I will try to give a try if I get the time. |
Hi @nazbrok have you managed to implement it in C#? |
Hi @nazbrok and @BifrostTitan I'm getting this error of this issue in some transactions! I saw that has a commit fixing this eac7430 but seams to be on a on hold PullRequest #428 |
Hello guys ! I don't see any signature for : GetTransaction , that takes maxSupportedTransactionVersion as a parameter. Did you guys code a new signature for GetTransaction and GetBlock that uses this maxSupportedTransactionVersion parameter ? Thanks ! |
Why is it closed? Are you going to merge it? It seems still not fixed. |
It already been patched. Compile from source to use the latest version. The nuget package will be updated soon |
Solana introduced versioned transaction
currently Solnet support only LEGACY transaction because the optional parameter
maxSupportedTransactionVersion
is not set on getBlock and getTransactionto my understanding we just need to always set this optional parameter to 0 to support both mode.
To Reproduce
Metaplex action house started to use versioned transaction.
Here is a (failed) TX using versioned transaction : X1GTDnoauLQvM7VoZjC492dVY1YRmYCbUDPX7WwyuiWizFyigJfdGJh61Qrkr7hjAqoo8aVWJLWXEeRgqv7JQPp
calling getTransaction for this tx return this json
{"jsonrpc":"2.0","error":{"code":-32015,"message":"Transaction version (0) is not supported by the requesting client. Please try the request again with the following configuration parameter: \"maxSupportedTransactionVersion\": 0"},"id":54}
The text was updated successfully, but these errors were encountered: