Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] call to getTransaction on a versioned transaction fail #426

Closed
nazbrok opened this issue Dec 19, 2022 · 10 comments
Closed

[Bug] call to getTransaction on a versioned transaction fail #426

nazbrok opened this issue Dec 19, 2022 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@nazbrok
Copy link
Contributor

nazbrok commented Dec 19, 2022

Solana introduced versioned transaction

currently Solnet support only LEGACY transaction because the optional parameter maxSupportedTransactionVersion is not set on getBlock and getTransaction

to my understanding we just need to always set this optional parameter to 0 to support both mode.

To Reproduce

Metaplex action house started to use versioned transaction.
Here is a (failed) TX using versioned transaction : X1GTDnoauLQvM7VoZjC492dVY1YRmYCbUDPX7WwyuiWizFyigJfdGJh61Qrkr7hjAqoo8aVWJLWXEeRgqv7JQPp

calling getTransaction for this tx return this json

{"jsonrpc":"2.0","error":{"code":-32015,"message":"Transaction version (0) is not supported by the requesting client. Please try the request again with the following configuration parameter: \"maxSupportedTransactionVersion\": 0"},"id":54}

@nazbrok nazbrok added the bug Something isn't working label Dec 19, 2022
@BifrostTitan
Copy link
Contributor

eac7430

Added support for versioned transactions. I believe compile message needs a update to write versioned transaction from the client not totally sure so this only covers the reading portion.

@nazbrok
Copy link
Contributor Author

nazbrok commented Jan 17, 2023

eac7430

Added support for versioned transactions. I believe compile message needs a update to write versioned transaction from the client not totally sure so this only covers the reading portion.

indeed this PR only aim to fix the reading portion for the moment.
My knowledge of Solana isn't great so I didn't dive too much into the writing part (yet)

@nazbrok
Copy link
Contributor Author

nazbrok commented Jan 17, 2023

Well looks like this PR only fix the call to getTransaction and getBlock and is finally not enough for the reading portion

The transaction format changed so Solnet currently fail to decode the tx because of the table lookup I think.

@BifrostTitan
Copy link
Contributor

eac7430
This PR allows you to get & decode versioned transactions successfully. You will no longer get the client warning that you mentioned above. The response for the TX in your issue was related to requiring permission from the metaplex auction house. Feel free to pull from my fork and test yourself.
Everything is available in typescript in the Solana Javascript SDK. It just needs to be coded in C# and added to solnet. Ill see what needs to be updated to allow versioned txs to be built and sent from solnet

@nazbrok
Copy link
Contributor Author

nazbrok commented Jan 17, 2023

thanks, your implementation is better.

I quickly looked at the typescript implementation, I will try to give a try if I get the time.

@esculapeso
Copy link

Hi @nazbrok have you managed to implement it in C#?

@rwspatin
Copy link

rwspatin commented Jan 8, 2024

Hi @nazbrok and @BifrostTitan I'm getting this error of this issue in some transactions! I saw that has a commit fixing this eac7430 but seams to be on a on hold PullRequest #428
Did you have some update of this issue? Do you need any help ?

@lowki1119
Copy link

Hello guys ! I don't see any signature for : GetTransaction , that takes maxSupportedTransactionVersion as a parameter.

Did you guys code a new signature for GetTransaction and GetBlock that uses this maxSupportedTransactionVersion parameter ?

Thanks !

@danikishin
Copy link

Why is it closed? Are you going to merge it? It seems still not fixed.

@BifrostTitan
Copy link
Contributor

It already been patched. Compile from source to use the latest version. The nuget package will be updated soon

eac7430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants