Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON report should properly contain "major" as change type for breaking changes #186

Open
devmil opened this issue Oct 9, 2024 · 0 comments
Open

JSON report should properly contain "major" as change type for breaking changes #186

devmil opened this issue Oct 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@devmil
Copy link
Member

devmil commented Oct 9, 2024 •
edited
Loading

Describe the bug
Widening the return type is treated as minor change but can break consumer code

update: The problem is the JSON report that does not contain "major" in the change type field.

To Reproduce

dart-lang/ecosystem#304 (comment)

Actual and Expected behavior
the type field contains "minor" as it is only populated for non breaking changes
@devmil devmil added the bug Something isn't working label Oct 9, 2024
@devmil devmil mentioned this issue Oct 9, 2024
Closed
7 tasks
@devmil devmil changed the title Widening return types should be treated as a breaking change JSON report should properly contain "major" as change type for breaking changes Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: widening return types is not breaking bmw-tech/dart_apitool
1 participant
@devmil