Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Easy] - consistency with how objects are added to Global #128

Closed
jasonwilliams opened this issue Oct 2, 2019 · 1 comment
Closed

[Easy] - consistency with how objects are added to Global #128

jasonwilliams opened this issue Oct 2, 2019 · 1 comment
Assignees
@DomParfitt
Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Oct 2, 2019 •
edited
Loading

object, console, math, function, json should follow the same pattern as String, Regex below
https://github.com/jasonwilliams/boa/blob/master/src/lib/realm.rs#L55-L59

Example to follow:

Here is an example of Boolean being changed to create_constructor
jasonwilliams@e35b66b#diff-9c85558881ecea17184e97fb52b0882b
@jasonwilliams jasonwilliams added the Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com label Oct 2, 2019
@jasonwilliams jasonwilliams changed the title consistency with how objects are added to Global [Easy] - consistency with how objects are added to Global Oct 2, 2019
@jasonwilliams jasonwilliams added the good first issue Good for newcomers label Oct 2, 2019
@DomParfitt
Copy link
Contributor

I'd be interested in having a go at this.

This was referenced Oct 3, 2019
Merged
Merged
Merged
@DomParfitt DomParfitt mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DomParfitt DomParfitt

Labels
good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonwilliams @DomParfitt