Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for "uglified" JS #564

Closed
Razican opened this issue Jul 15, 2020 · 2 comments · Fixed by #581
Closed

Add benchmarks for "uglified" JS #564

Razican opened this issue Jul 15, 2020 · 2 comments · Fixed by #581
Assignees
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request
Milestone

Comments

@Razican
Copy link
Member

Razican commented Jul 15, 2020

Currently, all of our benchmarks take non-uglified JavaScript as input. This is fine for some scenarios, but we should also have benchmarks for "uglified" or "minified" JavaScript.

This usually creates smaller variable and function names, and removes spaces and new lines, which should speed up parsing and even a bit the execution.

@Razican Razican added enhancement New feature or request benchmark Issues and PRs related to the benchmark subsystem. labels Jul 15, 2020
@Razican Razican added this to the v0.10.0 milestone Jul 15, 2020
@neeldug
Copy link
Contributor

neeldug commented Jul 17, 2020

I was wondering roughly for the test cases, whether it should have both a regular and uglified test case for comparison, and also roughly how long the test case should be for a reliable and significant benchmark?

@Razican
Copy link
Member Author

Razican commented Aug 14, 2020

I was wondering roughly for the test cases, whether it should have both a regular and uglified test case for comparison, and also roughly how long the test case should be for a reliable and significant benchmark?

It shouldn't be too long. With a small benchmark we should have enough information, since we do a statistical analysis. As far as I can see in the PR, I think that should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants