Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error builtin] does not output "name" property correctly #791

Closed
croraf opened this issue Oct 4, 2020 · 3 comments · Fixed by #749
Closed

[Error builtin] does not output "name" property correctly #791

croraf opened this issue Oct 4, 2020 · 3 comments · Fixed by #749
Assignees
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics

Comments

@croraf
Copy link
Contributor

croraf commented Oct 4, 2020

Describe the bug
Error builtin and its subclasses don't output "name" property correctly

To Reproduce
new Error().name;
should show "Error", instead it shows Uncaught "Error": ""

also new SyntaxError().name;
should show "SyntaxError", instead it shows Uncaught "SyntaxError": ""

Environment

  • OS: [e.g. Fedora Linux]
  • Version: [e.g. 32]
  • Target triple: [e.g. x86_64-unknown-linux-gnu]
  • Rustc version: [e.g. rustc 1.43.0 (4fb7144ed 2020-04-20), running rustc -V]

Additional context

@croraf croraf added the bug Something isn't working label Oct 4, 2020
@HalidOdat HalidOdat added the builtins PRs and Issues related to builtins/intrinsics label Oct 4, 2020
@HalidOdat
Copy link
Member

@croraf I think #749 should fix this issue, right? since new Error() or Error() just throws the error immediately

@croraf
Copy link
Contributor Author

croraf commented Oct 4, 2020

I don't know if it will fix it, but if "new Error()" throws immediately, we should definitely prioritize that PR, and then check this again.

@RageKnify RageKnify linked a pull request Oct 4, 2020 that will close this issue
@RageKnify
Copy link
Member

Yeah, #749 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants