Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous integration to ryu-js like boa #3

Closed
HalidOdat opened this issue Jul 13, 2020 · 5 comments · Fixed by #29
Closed

Add continuous integration to ryu-js like boa #3

HalidOdat opened this issue Jul 13, 2020 · 5 comments · Fixed by #29
Labels
CI enhancement New feature or request

Comments

@HalidOdat
Copy link
Member

No description provided.

@HalidOdat HalidOdat added enhancement New feature or request CI labels Jul 13, 2020
@HalidOdat
Copy link
Member Author

Nevermind the the crate already has a github/workflow, so closing this.

@HalidOdat
Copy link
Member Author

HalidOdat commented Jul 14, 2020

I'm reopening this because the CI is not complete, it does not have rustfmt, clippy, etc

@HalidOdat HalidOdat reopened this Jul 14, 2020
@Razican
Copy link
Member

Razican commented Jul 14, 2020

We should also add some extra lints we use in Boa.

@HalidOdat
Copy link
Member Author

HalidOdat commented Jul 14, 2020

We should also add some extra lints we use in Boa.

That would be awesome!! :)

Also having some benchmarks would be nice too.

Edit: the crate has benchmarks but they are nightly bench ones I don't know how compatible it is with critcmp it is. since id does not use criterion https://github.com/boa-dev/ryu-js/blob/master/benches/bench.rs

@Razican
Copy link
Member

Razican commented Jul 14, 2020

Also having some benchmarks would be nice too.

Edit: the crate has benchmarks but they are nightly bench ones I don't know how compatible it is with critcmp it is. since id does not use criterion https://github.com/boa-dev/ryu-js/blob/master/benches/bench.rs

I think we could start using criterion for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants