Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ExaConnectOptionsBuilder methods to consume self #10

Closed
bobozaur opened this issue Sep 5, 2023 · 0 comments · Fixed by #15
Closed

Tweak ExaConnectOptionsBuilder methods to consume self #10

bobozaur opened this issue Sep 5, 2023 · 0 comments · Fixed by #15
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bobozaur
Copy link
Owner

bobozaur commented Sep 5, 2023

ExaConnectOptionsBuilder setters take &mut self, but building the ExaConnectOptions requires ownership. The type was initially made to be used internally and only afterwards made public, but this design makes method chaining and building impossible.

Therefore, it might be better to simply take mut self in setters to make the builder more ergonomic for consumer code.

@bobozaur bobozaur added enhancement New feature or request good first issue Good for newcomers labels Sep 5, 2023
@bobozaur bobozaur linked a pull request Sep 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant