Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WikiWords unescaped even when use_wikilinks = 0? #18

Open
etherealvisage opened this issue Aug 24, 2012 · 0 comments
Open

WikiWords unescaped even when use_wikilinks = 0? #18

etherealvisage opened this issue Aug 24, 2012 · 0 comments

Comments

@etherealvisage
Copy link

Hello:

I've found an edge case in Text::MultiMarkdown (1.000034, latest from CPAN) regarding wikilinks this time. Line 318 of MultiMarkdown.pm reads:

$text = $self->_UnescapeWikiWords($text);

But this implies that it will perform unescaping even when use_wikilinks is not set. It seems to me like this should be changed to something like:

$text = $self->_UnescapeWikiWords($text) if ($self->_UseWikiLinks());

For slightly more consistent behaviour.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant