Defer GitHub API creation to PR handlers #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a GitHub context is created, tokens are checked and refreshed. Because GitHub tokens were being used across multiple jobs in a repository-queue, it could happen that the tokens were expired once a job later in the queue was started. This change makes sure the GitHub API is created when the jobs is going to be processed. That way the tokens are checked at the beginning of each jobs, instead of at the beginning of the job queue.
bobvanderlinden
changed the title
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a GitHub API is created, tokens are checked and refreshed. Because GitHub tokens were being used across multiple jobs in a repository-queue, it could happen that the tokens were expired once a job later in the queue was started.
This change makes sure the GitHub API is created when a job is going to be processed. That way the tokens are checked at the beginning of each jobs, instead of at the beginning of the job queue.
It does this by running
app.auth(installationId, log)each time a job is started inRepositoryWorker.installationIdandappare hidden forRepositoryWorker{s,}by wrapping theapp.authcall insidecreateGitHubAPI.