Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Felix Okwanma- Outreachy Contributions #25

Open
robinokwanma opened this issue Mar 16, 2023 · 9 comments
Open

Felix Okwanma- Outreachy Contributions #25

robinokwanma opened this issue Mar 16, 2023 · 9 comments

Comments

@robinokwanma
Copy link

robinokwanma commented Mar 16, 2023

Task #6 : Explore NYC taxi trips data set

I plotted a line graph to show the comparison between the tips for green_tripdata_2020-02.parquet and green_tripdata_2022-01.parquet
You can find the full code and screenshot of output in my githubgist

@robinokwanma
Copy link
Author

robinokwanma commented Mar 16, 2023

Task #4 Set up a local environment for Bokeh

My Local Environment was set up and server running

image
image

@robinokwanma
Copy link
Author

robinokwanma commented Mar 16, 2023

Task #7 Update a Bokeh example plot

A pull request was made to update the histogram.py plot color to a Highcontrast color palette. Attached here is my pull request.

#13021

Initial Plot
before

Updated Plot
after

@robinokwanma
Copy link
Author

@pavithraes @bryevdv

I'm open to reviews and updates. Cheers!

@robinokwanma
Copy link
Author

Hi @bryevdv @pavithraes , I need to make an enquiry on the timeline for the Project #2

Can you give some insight on how broad this project will be? And how long it is projected before completion

@bryevdv
Copy link
Member

bryevdv commented Mar 21, 2023

@robinokwanma the outreachy timeline and time commitment is set by outreachy:

So for the accepted intern the internship period is from May 29, 2023 to Aug. 25, 2023, ~30hrs/week. The projects are somewhat open-ended so we'd try to help whoever is selected accomplish as much as possible in that time.

@bryevdv
Copy link
Member

bryevdv commented Mar 21, 2023

@robinokwanma noting here that the micro-tasks are satisfied!

@robinokwanma
Copy link
Author

robinokwanma commented Mar 21, 2023

Thank You @bryevdv , Although you lost me on the last comment. I didn't quite get it

@pavithraes
Copy link
Member

@robinokwanma Thanks for your contributions, your submission for NYC taxi data analysis looks nice. I especially appreciate your code with all the useful comments, and your structurally-complete plot with titles and labels. :)

A few optional notes on what you can improve, in decreasing order of priority:

  • You're visualizing an interesting feature, I think the dataset being used for 2022 is January, you can update it to Feb; and in your plot I think the x-axis-label "Month of February" will be more appropriate.
  • I'd encourage you to break your work into separate code cells, and add some narrative text to improve presentation of your notebook. For example, this bokeh tutorial is created with jupyter notebooks, and you can see markdown cells as well as code cells: https://github.com/bokeh/tutorial/blob/main/notebooks/04_basic_plots.ipynb
  • After the plot, you can consider adding a section with your comments on how the tip amount changed.

Although you lost me on the last comment. I didn't quite get it
Bryan meant we can formally consider your microtask completed, and you can add it to your final outreachy application.

Whenever you feel ready, please go ahead and add this to your application! I don't think another review will be required, but let me know if you'd like me to take another look. :)

@robinokwanma
Copy link
Author

Thank You Very Much @pavithraes , all changes have been made and updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants