[Bug] RELAYHOST_PASSWORD printed out

[spali]

I assume this is a bug :)

‣ NOTE  Forwarding all emails to [mail.example.com]:587 using username [email protected] and password (redacted).
[mail.example.com]:587 [email protected]:MYPASSWORD
‣ INFO  Using default private network list for trusted networks.

Set via docker compose env variables:

      RELAYHOST: ${SMTP_RELAYHOST:?}
      RELAYHOST_USERNAME: ${SMTP_RELAYHOST_USERNAME:?}
      RELAYHOST_PASSWORD: ${SMTP_RELAYHOST_PASSWORD:?}

Not sure which line is responsible for the print of the password, but I assume somewhere here:

docker-postfix/scripts/common-run.sh

Lines 201 to 208 in a1a2082

	if [[ -f /etc/postfix/sasl_passwd ]]; then
	if ! grep -F "$SASL_RELAYHOST $RELAYHOST_USERNAME:$RELAYHOST_PASSWORD" /etc/postfix/sasl_passwd; then
	sed -i -e "s/^$SASL_RELAYHOST .*$/d" /etc/postfix/sasl_passwd
	echo "$SASL_RELAYHOST $RELAYHOST_USERNAME:$RELAYHOST_PASSWORD" >> /etc/postfix/sasl_passwd
	fi
	else
	echo "$SASL_RELAYHOST $RELAYHOST_USERNAME:$RELAYHOST_PASSWORD" >> /etc/postfix/sasl_passwd
	fi

Maybe the grep should be redirected to /dev/null ?

[bokysan]

Thank you for the report.

grep's missing -q.

[geekscrapy]

seeing this also