Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress 3.8.x (in-)compatibility #67

Closed
rmpel opened this issue Mar 31, 2015 · 5 comments
Closed

WordPress 3.8.x (in-)compatibility #67

rmpel opened this issue Mar 31, 2015 · 5 comments
Labels

Comments

@rmpel
Copy link

rmpel commented Mar 31, 2015

According to your page on WordPress.org, this plugin is compatible with WP 3.6 and up, but on 8 individual WordPress 3.8.x sites the plugin does NOT work properly. The History page (WP-Admin > Dashboard > Simple History) stays blank
simple-history-blank-screen

In some cases the console.log reports something about about an invalid data pseudo selector (?? paraphrased). The javascript error occurs in jQuery, but upgrading jQuery to 1.11 or even a 2.0 version does not help.
I've searched the plugin for :data in order to find and debug the problem with no success.

I've tried with 2.0.21, 2.0.22, 2.0.24 and 2.0.26. I hope you can tell me what to do about this, or at least point me in the right direction so I can (possibly) debug this for you.

@bonny
Copy link
Owner

bonny commented Apr 1, 2015

Just created a new site here with WordPress 3.8 and tried Simple History on it. It seems to work with no problems (see screenshot). Any other plugin you have installed that may interfere with Simple History? Could you perhaps open the console before loading the page again and see if it outputs anything?

image

@rmpel
Copy link
Author

rmpel commented Apr 1, 2015

Thanks for your response, I'm baffled! And shame on me for not testing with a vanilla WP38. The sites I tested on all have different themes/plugins, there's not one that is on all sites. (That's why I didn't look elsewhere, sorry)
I will keep trying, thank you for your nudge in the right direction :)

@rmpel
Copy link
Author

rmpel commented Apr 1, 2015

Found it (I think...)
The problem as far as I can now determine is in
simple-history/dropins/SimpleHistorySidebarDropin.php
around line 130
it says: if not english, then check for translations
(our sites are Dutch)
then it requires the file wp-admin/includes/translation-install.php which does not exist before version 4.0
the wp-admin page breaks on the require_once and when skipped by substituting include_once breaks on the function call wp_get_available_translations.
Footer is not printed, ergo scripts are not ran, ergo history table stays empty.

So, I'm sorry to say; simple-history is broken on all WordPress sites before 4.0 in a non-english language.

Hope this helps you solve the issue :)

@bonny
Copy link
Owner

bonny commented Apr 1, 2015

thanks! great debugging. will fix it then :)

@bonny bonny added the bug label Apr 1, 2015
@bonny bonny closed this as completed in 1aa2f01 Apr 1, 2015
@bonny
Copy link
Owner

bonny commented Apr 1, 2015

ok, brand new version only for you: https://wordpress.org/plugins/simple-history/changelog/
please let me know if it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants