Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoWriter drops frames when using multiple subscriptions with different frame resolutions #1467

Closed
glopesdev opened this issue Jul 14, 2023 · 0 comments · Fixed by #1468
Closed

VideoWriter drops frames when using multiple subscriptions with different frame resolutions #1467

glopesdev opened this issue Jul 14, 2023 · 0 comments · Fixed by #1468
Labels
bug Something isn't working
Milestone
2.8

Comments

@glopesdev
Copy link
Member

To reproduce:

  • Create a video logging workflow with CreateObservable > Merge where each observable emits frames with different resolutions
  • Send the videos to separate files
  • All videos will be created, but they will all have one frame except the last

The cause seems to be an internally cached Size inside the VideoWriter implementation. The frame size needs to be cached on a per-subscription basis.
@glopesdev glopesdev added the bug Something isn't working label Jul 14, 2023
@glopesdev glopesdev added this to the 2.8 milestone Jul 14, 2023
@glopesdev glopesdev mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.8
Development

Successfully merging a pull request may close this issue.

Ensure VideoWriter frame size is cached per subscription glopesdev/bonsai
1 participant
@glopesdev