Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment config files are not compatible across platforms #1864

Closed
glopesdev opened this issue Jun 28, 2024 · 1 comment · Fixed by #1893
Closed

Environment config files are not compatible across platforms #1864

glopesdev opened this issue Jun 28, 2024 · 1 comment · Fixed by #1893
Labels
bug Something isn't working
Milestone

Comments

@glopesdev
Copy link
Member

glopesdev commented Jun 28, 2024

Currently the local environment .config file relies on OS-specific path separators to determine assembly locations and native library folders. Because of this, it is currently not possible to version .config files across platforms, e.g. Windows and Linux, since the direction of slashes is different.

A proposal was made in #1572 to resolve this by simply removing the explicit locations from the config file entirely. Unfortunately there are challenges to implementing this quickly, so it might be easier for now to simply normalize the paths to the current OS when reading, and normalize to a fixed convention when writing the config file, e.g. to linux-style for increased compatibility.

@glopesdev glopesdev added the bug Something isn't working label Jun 28, 2024
@glopesdev glopesdev added this to the 2.8.4 milestone Jun 28, 2024
@glopesdev
Copy link
Member Author

glopesdev commented Jul 1, 2024

One possible edge case (or maybe not even) to consider is the CLI flag --lib which allows passing custom folders. This would still work if we normalize to forward slashes only on saving the .config file.

Better yet, we can do nothing and just assume that --lib is always called in an OS-specific setting so it is the caller's responsibility to ensure that any specified path is valid for the current OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant