Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using CI run counter for FileVersion #1938

Open
glopesdev opened this issue Jul 25, 2024 · 0 comments
Open

Avoid using CI run counter for FileVersion #1938

glopesdev opened this issue Jul 25, 2024 · 0 comments
Labels
proposal Request for a new feature

Comments

@glopesdev
Copy link
Member

glopesdev commented Jul 25, 2024

According to the documentation for FileVersion the resolution for individual components of the version number is 16-bit.

It might take a while still to hit the max 65535 value judging from the rate at which we are currently burning through CI in both individual commits to branches and PRs, but still I was wondering whether there might be a better approach to incrementing the revision counter. I was also interested in having a number that would somehow relate to how far away we are from the last release.

It looks like python CI wheels automatically set both dev and ci counter suffixes to match the number of commits since last tag, which seems pretty reasonable. To resolve clashes using this counter in package IDs they append also the commit hash using +sha8abcd for example.

@glopesdev glopesdev added the proposal Request for a new feature label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant