Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package update button indicates "Package updates are available" even when that statement is false #2003

Open
cjsha opened this issue Sep 6, 2024 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@cjsha
Copy link

cjsha commented Sep 6, 2024

This button indicates package updates are available even when there aren't actually any package updates available.

Screenshot 2024-09-06 110523

I suppose it should be greyed out with a different tooltip i.e. "No package updates available" when there are no package updates available?

I like the idea behind this feature a lot btw.

@cjsha
Copy link
Author

cjsha commented Sep 6, 2024

I'm sorry, I didn't realize 2.9 feedback should go in the discussions, you explicitly mention that in the 2.9 pre-release announcement. I'm going to close this and make it a comment in the discussion.

@cjsha cjsha closed this as completed Sep 6, 2024
@glopesdev glopesdev added this to the 2.9 milestone Sep 6, 2024
@glopesdev glopesdev added the bug Something isn't working label Sep 6, 2024
@glopesdev
Copy link
Member

glopesdev commented Sep 6, 2024

@cjsha Thanks for the feedback, this is actually probably related to package type filtering, where updates are available but being filtered out in the package manager dialog. I am reopening the issue and will investigate.

I suppose it should be greyed out with a different tooltip i.e. "No package updates available" when there are no package updates available?

This is also a great idea and probably better than the current hiding of the button which makes it harder to discover (this feature has actually been there for a long time).

@glopesdev glopesdev reopened this Sep 6, 2024
@cjsha
Copy link
Author

cjsha commented Sep 6, 2024

ah you're right. I needed to check that "Show Dependencies" box for the available updates to appear. I'm not accustomed to that checkbox.

But now that I've updated, Bonsai crashes when I open the workflow editor in the portable Bonsai 2.9 environment. The only packages I had previously installed was the starter pack.

Here is a gif of me updating packages and the workflow editor crashing afterwards.

bonsai-package-update

Here is a gif of me trying to open the workflow editor thereafter. I can confirm that the workflow editor was opening prior to downloading those updates.

bonsai-crash-due-to-update

I'm not sure what the best way to provide troubleshooting details, if you want them, but it seems repeatable on my machine.

@glopesdev
Copy link
Member

@cjsha yeah, this is probably some dependency that breaks, we need to be much more careful with constraining updates if we are to embrace NuGet fully.

Thanks for the report, will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants